[PATCH] osmo-sgsn[master]: SGSN: uncomment BSSGP vty tests

Max gerrit-no-reply at lists.osmocom.org
Fri Oct 20 11:40:39 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/4353

to look at the new patch set (#2).

SGSN: uncomment BSSGP vty tests

Change-Id: I9181fc0ecd91e96bf6532aa89b811552009a1b7d
---
M tests/vty_test_runner.py
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/53/4353/2

diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py
index 9be8d03..104bba4 100644
--- a/tests/vty_test_runner.py
+++ b/tests/vty_test_runner.py
@@ -150,10 +150,8 @@
         self.assert_(res.find('Encapsulation NS-UDP-IP') >= 0)
         self.assertTrue(self.vty.verify('show bssgp', ['']))
         self.assertTrue(self.vty.verify('show bssgp stats', ['']))
-        # TODO: uncomment when the command does not segfault anymore
-        # self.assertTrue(self.vty.verify('show bssgp nsei 123', ['']))
-        # self.assertTrue(self.vty.verify('show bssgp nsei 123 stats', ['']))
-
+        self.assertTrue(self.vty.verify('show bssgp nsei 123', ['']))
+        self.assertTrue(self.vty.verify('show bssgp nsei 123 stats', ['']))
         self.assertTrue(self.vty.verify('show sgsn', ['']))
         self.assertTrue(self.vty.verify('show mm-context all', ['']))
         self.assertTrue(self.vty.verify('show mm-context imsi 000001234567', ['No MM context for IMSI 000001234567']))

-- 
To view, visit https://gerrit.osmocom.org/4353
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9181fc0ecd91e96bf6532aa89b811552009a1b7d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list