osmo-bsc[master]: log: log the sccp message type of messages sent

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Oct 20 11:21:17 UTC 2017


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/4351/1/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

Line 346: 		osmo_bsc_sigtran_send(conn, resp);
I think rather than adding a hand-crafted line with a hand-crafted string of the messag type, you would want to add this ti osmo_bsc_sigtran_send() and parse/dereference the header and use a value_string array to resolve the message type. I prsume we probably have such an array of BSSAP message types alrady somewhere?


-- 
To view, visit https://gerrit.osmocom.org/4351
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6736f15ddc03e5f70c3504abffbae6cbf766c9d7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list