[PATCH] libosmocore[master]: Expand osmo_gettimeofday() docs

Max gerrit-no-reply at lists.osmocom.org
Fri Oct 20 10:48:58 UTC 2017


Review at  https://gerrit.osmocom.org/4367

Expand osmo_gettimeofday() docs

Change-Id: I9bc835aea56f5f2fb652bb5ab3405e354ba3b95c
Related: OS#2586
---
M src/timer_gettimeofday.c
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/4367/1

diff --git a/src/timer_gettimeofday.c b/src/timer_gettimeofday.c
index 1bf714e..4298805 100644
--- a/src/timer_gettimeofday.c
+++ b/src/timer_gettimeofday.c
@@ -33,7 +33,13 @@
 
 /*! shim around gettimeofday to be able to set the time manually.
  * To override, set osmo_gettimeofday_override == true and set the desired
- * current time in osmo_gettimeofday_override_time. */
+ * current time in osmo_gettimeofday_override_time.
+ *
+ * N. B: gettimeofday() is affected by discontinuous jumps in the system time
+ *       (e.g., if the system administrator manually changes the system time).
+ *       Hence this should NEVER be used for elapsed time computation.
+ *       Instead, clock_gettime(CLOCK_MONOTONIC, ..) should be used for that (with similar shim if necessary).
+ */
 int osmo_gettimeofday(struct timeval *tv, struct timezone *tz)
 {
 	if (osmo_gettimeofday_override) {

-- 
To view, visit https://gerrit.osmocom.org/4367
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bc835aea56f5f2fb652bb5ab3405e354ba3b95c
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>


More information about the gerrit-log mailing list