osmo-hlr[master]: ctrl: completely replace all CTRL commands

Max gerrit-no-reply at lists.osmocom.org
Thu Oct 19 10:23:13 UTC 2017

Patch Set 2:

> are not of interest to any osmo-hlr user yet

than what's the point of including it?

> CTRL command 'subscriber.by-*.info'

will it break if you just omit "#if 0"?

I really dislike the idea of including dead code: it always raises the questions for any person reading this code later on, it silently bitrot and it doesn't serve any particular purpose. If we need it to illustrate some point than it's better to include comment which illustrate this point with words. If it's there for completeness sake than uncomment it and let the caller ignore it.

To view, visit https://gerrit.osmocom.org/4311
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No

More information about the gerrit-log mailing list