osmo-hlr[master]: ctrl: completely replace all CTRL commands

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 19 01:11:26 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/4311/2/src/ctrl.c
File src/ctrl.c:

Line 156: /* not used yet */
> Erm, could you clarify? Who's using the other part of the same function?
This is one large printf (to avoid reallocating string memory), in the first #if 0 are the format strings and in below #if 0 are the arguments corresponding to the format strings of the first #if 0. I'm excluding these, because they are variables that already exist in the struct (modeled after HLR specs I presume) but are not of interest to any osmo-hlr user yet, because there is no code actually using these features. Does this answer your question?

Or did you mean who is using print_subscr_info()? The CTRL command 'subscriber.by-*.info'.


-- 
To view, visit https://gerrit.osmocom.org/4311
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list