osmo-ggsn[master]: ippool: Implement and use blacklist instead of blindly using...

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Oct 16 20:48:19 UTC 2017

Patch Set 4:

(1 comment)

sorry, one more iteration for calloc -> talloc, but then I think it's ready!

File ggsn/ggsn.c:

Line 165: 		*blacklist = calloc(len, sizeof(struct in46_prefix));
we have the apn_ctx which is a talloc object, so we could slave this to the apn_ctx instead of using generic libc allocators (which we normally don't) for easier tracking of memory allocations.

To view, visit https://gerrit.osmocom.org/4256
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e91f7280d60490c858a769dd578c1c8e54e9243
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

More information about the gerrit-log mailing list