osmo-ggsn[master]: tun: Convert tun_ipv6_linklocal_get to be more generic

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Oct 16 13:26:13 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4291/1/lib/tun.c
File lib/tun.c:

Line 788: 			return 0;
we're not happy with the old code making assumptions such as where the gateway IP address is within the subnet.  In your propsoed patch, we also make assumtions: That there's only one non-link-local address (for each IPv4 and IPv6).  It should be rather easy to iterate over all such addresses and add all of them to the blacklist, shouldn't it?  Basically if there are 10 local ip addresses configured in the pool, we should skip all 10.


-- 
To view, visit https://gerrit.osmocom.org/4291
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I277af191dc611b6bbcb83479f4ae338083740322
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list