libosmocore[master]: add function msgb_printf() to print formatted text into msg buf

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Oct 14 18:32:20 UTC 2017


Patch Set 3:

> That's regression test - it's not meant to be human-verifiable.

On the contrary. If we cannot easily see that the test is correct, the whole test is pointless. If it verifies arbitrary hex dumps and these hex dumps are plain wrong without us noticing, that's worse than no test. If anything in the code ever changes, we need to be able to work with the code and understand what it is doing without effort.

So yes, we can shape the strings such that reading hexdumps thereof is easy, like simply the alphabet from A-Z. But with these free form texts, the test output should definitely not be hex dumps.

-- 
To view, visit https://gerrit.osmocom.org/4200
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15e1af68616309555d0ed9ac5da027c9833d42e3
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list