osmo-bts[master]: Fix race condition in attribute reporting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Oct 13 14:46:37 UTC 2017


Patch Set 2:

>  I thought the style was to always put it in the beginning of the function. What's the general rule?

yes, I also misunderstood that once. The rule is to place var declarations at the beginning of each scope, yes. But if a given variable is only used within an inner scope like an if/for/while{} body, then declare that var only within that inner scope; there, again do so at the start of the scope.

-- 
To view, visit https://gerrit.osmocom.org/4232
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id36885e507c4a3203b5662c0fde12c5206174d82
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list