osmo-gsm-tester[master]: debug: Add voicecall related method to interactive shell

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Oct 13 14:35:34 UTC 2017


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/4151/1/suites/aoip_debug/interactive.py
File suites/aoip_debug/interactive.py:

Line 26:   cmd = prompt('Enter command: (q)uit (s)ms (g)et-registered (w)ait-registered, call-list [<ms_msisdn>], call-dial <src_msisdn> <dst_msisdn>, call-answer <ms_msisdn> <call_id>, call-hangup <ms_msisdn> <call_id>')
> I'd go for b, otherwise it's annoying while using it.
ok


Line 52:   elif cmd.startswith('call-list'):
> I know, I understand, but then you cannot pass parameters and you need to k
it would be a whole new intelligent parsing thing, I agree to keep it this way


https://gerrit.osmocom.org/#/c/4151/1/suites/debug/interactive.py
File suites/debug/interactive.py:

Line 45:   elif cmd.startswith('call-list'):
> At a later stage it may make sense to move it to a library, or to make it g
at some point it was possible to enter test scripts using pydb3, but I have somehow managed to break that and haven't figured out how to fix it again. It's all about python paths and setting a break point so that the debugger can match it with the test script. Fixing pydb3 use would indeed be the most flexible solution.


-- 
To view, visit https://gerrit.osmocom.org/4151
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2df68bf4fba0fb542eebdeb515a3dac6d5e575e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list