osmo-msc[master]: Remove pkg-config file

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 12 13:48:06 UTC 2017


Patch Set 4: Code-Review+1

(1 comment)

except for the 'make distcheck' failure this patch is good, right? Do you have other reasons to veto? (-2 means to me the entire direction of the patch is wrong, which to me it isn't)

https://gerrit.osmocom.org/#/c/4231/4/include/osmocom/msc/Makefile.am
File include/osmocom/msc/Makefile.am:

Line 73
AFAICT bsc_api.h must be added to noinst_HEADERS?
The other two already are in there, interestingly enough.


-- 
To view, visit https://gerrit.osmocom.org/4231
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15c0b4457c108c7791b0f30b79660d9e6d09b269
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list