osmo-bts[master]: Fix race condition in attribute reporting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Oct 12 12:54:59 UTC 2017


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/4232/1//COMMIT_MSG
Commit Message:

Line 21: it anyway.
It is good to show these reflections. What would need to happen to make this work properly? E.g. the TRX gets an OPSTART and we should be able to delay the ack until the trx is reay?


https://gerrit.osmocom.org/#/c/4232/1/src/common/oml.c
File src/common/oml.c:

Line 212: 	bool processed;
you can move that into the scope of the for loop


Line 234: 			out[attr_out_index] = attr[i]; 
trailing whitespace


-- 
To view, visit https://gerrit.osmocom.org/4232
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id36885e507c4a3203b5662c0fde12c5206174d82
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list