[MERGED] osmo-hlr[master]: cosmetic: db_hlr: SL3_TXT: clarify indenting

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Oct 11 20:25:30 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: cosmetic: db_hlr: SL3_TXT: clarify indenting
......................................................................


cosmetic: db_hlr: SL3_TXT: clarify indenting

Before, it looked like the nul term was within the if () body (despite no body
being present).

While at it, also remove one of the two tabs of indenting and put the opening
'do {' on its own line.

Change-Id: I8d03433b6fba90f4e46814bc54636bc3a444cc46
---
M src/db_hlr.c
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/db_hlr.c b/src/db_hlr.c
index 4bccca4..5db2c9e 100644
--- a/src/db_hlr.c
+++ b/src/db_hlr.c
@@ -30,12 +30,13 @@
 
 #define LOGHLR(imsi, level, fmt, args ...)	LOGP(DAUC, level, "IMSI='%s': " fmt, imsi, ## args)
 
-#define SL3_TXT(x, stmt, idx)					do {	\
-		const char *_txt = (const char *) sqlite3_column_text(stmt, idx);	\
-		if (_txt)						\
-			strncpy(x, _txt, sizeof(x));			\
-			x[sizeof(x)-1] = '\0';				\
-		} while (0)
+#define SL3_TXT(x, stmt, idx) 					\
+	do {							\
+		const char *_txt = (const char *) sqlite3_column_text(stmt, idx);\
+		if (_txt)					\
+			strncpy(x, _txt, sizeof(x));		\
+		x[sizeof(x)-1] = '\0';				\
+	} while (0)
 
 int db_subscr_get_by_imsi(struct db_context *dbc, const char *imsi,
 			  struct hlr_subscriber *subscr)

-- 
To view, visit https://gerrit.osmocom.org/4203
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d03433b6fba90f4e46814bc54636bc3a444cc46
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list