libosmo-abis[master]: unixsocket: fix a potential string overflow

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Oct 11 08:13:10 UTC 2017


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/4213/1/src/input/unixsocket.c
File src/input/unixsocket.c:

Line 235: 		strncpy(sock_path, line->sock_path, PATH_MAX - 1);
strncpy is not zero-terminating the buffer if it truncates. Pleaes consider osmo_strlcpy instead


-- 
To view, visit https://gerrit.osmocom.org/4213
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3ec741247d728232f8c07c94eb63f068597d80
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list