[MERGED] osmo-bts[master]: l1sap: Improve log msg when frame diff >1

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Oct 10 08:21:00 UTC 2017


Pau Espin Pedrol has submitted this change and it was merged.

Change subject: l1sap: Improve log msg when frame diff >1
......................................................................


l1sap: Improve log msg when frame diff >1

Print the two fn values to understand better the wrong behaviour.

Change-Id: I4f7b3ffbf7ce3a8d8d6872e4281ef228f4c5527f
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 1b3a3ad..763b355 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -456,7 +456,8 @@
 	frames_expired = info_time_ind->fn - btsb->gsm_time.fn;
 	if (frames_expired > 1) {
 		LOGP(DL1P, LOGL_ERROR,
-		     "Invalid condition detected: Frame difference is > 1!\n");
+		     "Invalid condition detected: Frame difference is %"PRIu32"-%"PRIu32" > 1!\n",
+	             info_time_ind->fn, btsb->gsm_time.fn);
 	}
 
 	/* Update our data structures with the current GSM time */

-- 
To view, visit https://gerrit.osmocom.org/4165
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f7b3ffbf7ce3a8d8d6872e4281ef228f4c5527f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>


More information about the gerrit-log mailing list