[MERGED] libosmocore[master]: auth: add OSMO_MILENAGE_IND_BITLEN_MAX

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: auth: add OSMO_MILENAGE_IND_BITLEN_MAX
......................................................................


auth: add OSMO_MILENAGE_IND_BITLEN_MAX

Will be used by OsmoHLR to validate VTY and CTRL input.

Change-Id: Ic39f3404d1a49ffd06070aa9897b36f219eacf4d
---
M include/osmocom/crypt/auth.h
M src/gsm/auth_milenage.c
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/crypt/auth.h b/include/osmocom/crypt/auth.h
index 7064c99..1b017c0 100644
--- a/include/osmocom/crypt/auth.h
+++ b/include/osmocom/crypt/auth.h
@@ -10,6 +10,7 @@
 #include <osmocom/core/utils.h>
 
 #define OSMO_A5_MAX_KEY_LEN_BYTES (128/8)
+#define OSMO_MILENAGE_IND_BITLEN_MAX 28
 
 /*! Authentication Type (GSM/UMTS) */
 enum osmo_sub_auth_type {
diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c
index e1a1dfb..2ddf712 100644
--- a/src/gsm/auth_milenage.c
+++ b/src/gsm/auth_milenage.c
@@ -112,7 +112,7 @@
 	 * { .ind_bitlen = 0, .ind = 0, .sqn = (desired_sqn - 1) }
 	 */
 
-	if (aud->u.umts.ind_bitlen > 28)
+	if (aud->u.umts.ind_bitlen > OSMO_MILENAGE_IND_BITLEN_MAX)
 		return -2;
 
 	seq_1 = 1LL << aud->u.umts.ind_bitlen;

-- 
To view, visit https://gerrit.osmocom.org/4158
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic39f3404d1a49ffd06070aa9897b36f219eacf4d
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>