This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(1 comment)
I don't understand the fix; but apart from that detail there, the code looks like it knows what it is doing.
https://gerrit.osmocom.org/#/c/4160/1/src/libbsc/system_information.c
File src/libbsc/system_information.c:
Line 301: if (len - i) {
this is actually
if (len != i)
and I guess it should either be that, or rather check something like
if (i < len)
--
To view, visit https://gerrit.osmocom.org/4160
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I443c5c5f937b490578354f3c8a0c5b92629f2794
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes