This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/4156/1/src/gsm/gsm23003.c File src/gsm/gsm23003.c: Line 36: for (len = 0; pos && *pos && len < max_digits; len++, pos++) I thought so far the idea was to "fail early". Why not check str == NULL and immediately return instead of checking pos everytime it's used? -- To view, visit https://gerrit.osmocom.org/4156 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I111fbf29228929f2cd6ffa06bcb1f69da223224e Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes