This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 5: (4 comments) https://gerrit.osmocom.org/#/c/3920/5//COMMIT_MSG Commit Message: Line 10: magic number all over the place Okay. What I would have liked to have in the commit message is the discussion of int vs. unsigned long in used types. Why is this change correct? Line 11: * use libosmocore's define for bit pretty-printer Make sure to increase the PKG_CONFIG dependency in configure.ac for the new feature we require! https://gerrit.osmocom.org/#/c/3920/5/src/bts.h File src/bts.h: Line 47: #define NO_FREE_TFI 0xffffffff Why not make this unsigned? We have at least one place where this was used as unsigned... https://gerrit.osmocom.org/#/c/3920/5/src/gprs_rlcmac_ts_alloc.cpp File src/gprs_rlcmac_ts_alloc.cpp: Line 131 You change the type in comparison. Not sure why we wanted it UL on this side? U for sure but L? -- To view, visit https://gerrit.osmocom.org/3920 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2699ceebf0cbec01652a02fa68ccc9e9419d0293 Gerrit-PatchSet: 5 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes