libosmocore[master]: Remove bogus error message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Oct 4 11:47:01 UTC 2017


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/3973/5/osmo-release.mk
File osmo-release.mk:

Line 6: NEW_VER := $(shell bumpversion --list --current-version $(VERSION) $(REL) --allow-dirty 2>/dev/null | awk -F '=' '{ print $$2 }')
I am referring to this line. This invocation of 'bumpversion' may produce error messages on stderr. You are silencing them. Let's not do that if other ways exist to keep the "bumpversion not found" message from appearing in each and every 'make' invocation, like Harald's separate release script: https://gerrit.osmocom.org/4127 .

Furthermore I am still waiting for an explanation of what bumpversion is intended to do for us in the first place.

Let's not start another tennis match of questions, please.


-- 
To view, visit https://gerrit.osmocom.org/3973
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6ab79fe2f6b502ea223aa72e929dd3c75f34b5c
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list