[MERGED] osmo-msc[master]: cosmetic: vlr: declare a struct in .h; drop unused header

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Oct 4 11:14:39 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: cosmetic: vlr: declare a struct in .h; drop unused header
......................................................................


cosmetic: vlr: declare a struct in .h; drop unused header

In vlr_core.h, "pre-declare" a struct used in function declaration.

In vlr_lu_fsm.c, gsup.h is not used, drop the #include.

Change-Id: I61d793c3001abbe6d381be1ae0bb350b07403e88
---
M src/libvlr/vlr_core.h
M src/libvlr/vlr_lu_fsm.c
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr_core.h b/src/libvlr/vlr_core.h
index 6ca54e8..310cd97 100644
--- a/src/libvlr/vlr_core.h
+++ b/src/libvlr/vlr_core.h
@@ -2,6 +2,8 @@
 
 #include <osmocom/msc/vlr.h>
 
+struct osmo_gsup_message;
+
 #define LOGGSUPP(level, gsup, fmt, args...) \
 	LOGP(DVLR, level, "GSUP(%s) " fmt, \
 	     (gsup)->imsi, \
diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c
index ea7529e..37fe235 100644
--- a/src/libvlr/vlr_lu_fsm.c
+++ b/src/libvlr/vlr_lu_fsm.c
@@ -21,7 +21,6 @@
 
 #include <osmocom/core/fsm.h>
 #include <osmocom/gsm/gsm48.h>
-#include <osmocom/gsm/gsup.h>
 #include <osmocom/msc/vlr.h>
 #include <osmocom/msc/debug.h>
 

-- 
To view, visit https://gerrit.osmocom.org/4078
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61d793c3001abbe6d381be1ae0bb350b07403e88
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list