[PATCH] osmo-bsc[master]: OML: check GPRS state when reporting status

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Nov 29 13:47:02 UTC 2017


Review at  https://gerrit.osmocom.org/5092

OML: check GPRS state when reporting status

If GPRS is enabled for the BTS but NSE, CELL or both NSVC are locked
than report it as degraded.

Related: OS#2486
Change-Id: I9dce1d3b0cabe149a90cfca58a3fe55f8d6a72bc
---
M src/libbsc/abis_nm.c
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/5092/1

diff --git a/src/libbsc/abis_nm.c b/src/libbsc/abis_nm.c
index c9f03e1..ec235a8 100644
--- a/src/libbsc/abis_nm.c
+++ b/src/libbsc/abis_nm.c
@@ -691,6 +691,18 @@
 	if (bts->mo.nm_state.administrative == NM_STATE_LOCKED)
 		return false;
 
+	if (bts->gprs.mode != BTS_GPRS_NONE) {
+		if (bts->gprs.cell.mo.nm_state.administrative == NM_STATE_LOCKED)
+			return false;
+
+		if (bts->gprs.nse.mo.nm_state.administrative == NM_STATE_LOCKED)
+			return false;
+
+		if (bts->gprs.nsvc[0].mo.nm_state.administrative == NM_STATE_LOCKED &&
+		    bts->gprs.nsvc[1].mo.nm_state.administrative == NM_STATE_LOCKED)
+			return false;
+	}
+
 	llist_for_each_entry(trx, &bts->trx_list, list) {
 		if (!trx->rsl_link)
 			return false;

-- 
To view, visit https://gerrit.osmocom.org/5092
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dce1d3b0cabe149a90cfca58a3fe55f8d6a72bc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list