[PATCH] osmo-bsc[master]: cleanup: gsm_data_shared.h: drop unused ROLE_*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 27 21:36:15 UTC 2017


Review at  https://gerrit.osmocom.org/5046

cleanup: gsm_data_shared.h: drop unused ROLE_*

While this header was still shared among several code trees, we had this ROLE
construct in place to exclude some parts in some trees. Since we're having one
copy per code base now, drop the ROLE #ifdefs and an unused void *role.

Change-Id: I4f0c337779d8e7266b6e02815d886728c4826bb9
---
M include/osmocom/bsc/gsm_data_shared.h
1 file changed, 0 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/46/5046/1

diff --git a/include/osmocom/bsc/gsm_data_shared.h b/include/osmocom/bsc/gsm_data_shared.h
index 310dfb6..671d2f0 100644
--- a/include/osmocom/bsc/gsm_data_shared.h
+++ b/include/osmocom/bsc/gsm_data_shared.h
@@ -466,15 +466,6 @@
 	int nominal_power;		/* in dBm */
 	unsigned int max_power_red;	/* in actual dB */
 
-#ifndef ROLE_BSC
-	struct trx_power_params power_params;
-	int ms_power_control;
-
-	struct {
-		void *l1h;
-	} role_bts;
-#endif
-
 	union {
 		struct {
 			struct {
@@ -848,7 +839,6 @@
 	int force_combined_si;
 	int bcch_change_mark;
 
-#ifdef ROLE_BSC
 	/* Abis NM queue */
 	struct llist_head abis_queue;
 	int abis_nm_pend;
@@ -910,8 +900,6 @@
 	char *pcu_sock_path;
 	struct pcu_sock_state *pcu_state;
 
-#endif /* ROLE_BSC */
-	void *role;
 };
 
 

-- 
To view, visit https://gerrit.osmocom.org/5046
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f0c337779d8e7266b6e02815d886728c4826bb9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list