python/osmo-python-tests[master]: Add rate counter dumper

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Nov 27 16:42:40 UTC 2017


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/5029/2/osmopy/rate_ctr2csv.py
File osmopy/rate_ctr2csv.py:

Line 71:                 args.output.write('group,counter,absolute,second,minute,hour,day\n')
One can do it this way, but generally it would be better to use a python module for CSV generation, don't you agree?


Line 80:                                 args.output.write('%s,%s,%s,%s,%s,%s,%s\n' % (gr, k, absolute, per_sec, per_min, per_hour, per_day))
one problem I see here is that the strings are not quoted.  Isn't it standard practise that only integers occur in non-quoted form of CSV, but all strings are quoted with ""?


-- 
To view, visit https://gerrit.osmocom.org/5029
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12b369434e4ee9b38f92872f297e1f3d4f0698c2
Gerrit-PatchSet: 2
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list