This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/5039 Remove leftover comments and checks It seems like rx previously had 'float' type. Remove the comments and checks which are not relevant since rx is 'int'. Change-Id: Idb4aad53667f88f9656c5bb1c52e7e75b385f446 Fixes: OS#2223 --- M src/common/power_control.c 1 file changed, 1 insertion(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/5039/1 diff --git a/src/common/power_control.c b/src/common/power_control.c index 78d2702..e040ee4 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -56,18 +56,9 @@ if (lchan->ms_power_ctrl.current != ms_power) return 0; - /* - * What is the difference between what we want and received? - * Ignore a margin that is within the range of measurement - * and MS output issues. - */ + /* What is the difference between what we want and received? */ rx = btsb->ul_power_target - rxLevel; - if (rx >= 0 && rx < 1) - return 0; - if (rx < 0 && rx > -1) - return 0; - /* We don't really care about the truncation of int + float */ cur_dBm = ms_pwr_dbm(band, ms_power); new_dBm = cur_dBm + rx; -- To view, visit https://gerrit.osmocom.org/5039 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb4aad53667f88f9656c5bb1c52e7e75b385f446 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de>