osmo-mgw[master]: MGCP: Connection Identifiers are hex strings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Nov 27 13:35:43 UTC 2017


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/4906/6/src/libosmo-mgcp/mgcp_msg.c
File src/libosmo-mgcp/mgcp_msg.c:

Line 346: 		     "endpoint:%x invalid ConnectionIdentifier (empty)\n",
> ...
I don't understand why you keep insisting on using a LOG line formatting that's inconsistent with all of the existing log statements in the MGW/MGCP code. Please don't apply "general rules" but most and foremost ensure it is consistent within one program.  If it needs to be changed, then one has to change all occurrences in a separate patch.


-- 
To view, visit https://gerrit.osmocom.org/4906
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0531a1b670d00cec50078423a2868207135b2436
Gerrit-PatchSet: 6
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list