osmo-mgw[master]: MGCP: Connection Identifiers are hex strings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 27 13:20:30 UTC 2017


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/4906/6/src/libosmo-mgcp/mgcp_conn.c
File src/libosmo-mgcp/mgcp_conn.c:

Line 87: 	OSMO_ASSERT(strlen(id) < MGCP_CONN_ID_LENGTH);
-1: you ignored my earlier comment. It's ok to disagree but if you do, please respond.


Line 135: 	OSMO_ASSERT(strlen(id) < MGCP_CONN_ID_LENGTH);
...


https://gerrit.osmocom.org/#/c/4906/6/src/libosmo-mgcp/mgcp_msg.c
File src/libosmo-mgcp/mgcp_msg.c:

Line 338: 		     "endpoint:%x invalid ConnectionIdentifier (missing)\n",
-1: ignored earlier comment on 0x


Line 346: 		     "endpoint:%x invalid ConnectionIdentifier (empty)\n",
...


-- 
To view, visit https://gerrit.osmocom.org/4906
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0531a1b670d00cec50078423a2868207135b2436
Gerrit-PatchSet: 6
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list