[MERGED] osmo-gsm-tester[master]: hlr: Rename conf_for API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 27 10:27:54 UTC 2017


Pau Espin Pedrol has submitted this change and it was merged.

Change subject: hlr: Rename conf_for API
......................................................................


hlr: Rename conf_for API

The HLR has more clients than the MSC, for instance the SGSN.

Change-Id: Idd5de7a828f0a627f69876a990f2ac1af0b578aa
---
M src/osmo_gsm_tester/osmo_hlr.py
M src/osmo_gsm_tester/osmo_msc.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/osmo_hlr.py b/src/osmo_gsm_tester/osmo_hlr.py
index b6ebf8a..f7dd80a 100644
--- a/src/osmo_gsm_tester/osmo_hlr.py
+++ b/src/osmo_gsm_tester/osmo_hlr.py
@@ -151,7 +151,7 @@
         finally:
             conn.close()
 
-    def conf_for_msc(self):
+    def conf_for_client(self):
         return dict(hlr=dict(ip_address=self.ip_address))
 
 # vim: expandtab tabstop=4 shiftwidth=4
diff --git a/src/osmo_gsm_tester/osmo_msc.py b/src/osmo_gsm_tester/osmo_msc.py
index ccf15fe..3ff2d6a 100644
--- a/src/osmo_gsm_tester/osmo_msc.py
+++ b/src/osmo_gsm_tester/osmo_msc.py
@@ -77,7 +77,7 @@
         config.overlay(values, self.suite_run.config())
         config.overlay(values, dict(msc=dict(ip_address=self.ip_address)))
         config.overlay(values, self.mgcpgw.conf_for_msc())
-        config.overlay(values, self.hlr.conf_for_msc())
+        config.overlay(values, self.hlr.conf_for_client())
         config.overlay(values, self.stp.conf_for_client())
         config.overlay(values, self.smsc.get_config())
 

-- 
To view, visit https://gerrit.osmocom.org/4996
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd5de7a828f0a627f69876a990f2ac1af0b578aa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list