osmo-gsm-tester[master]: modem: Add minimal GPRS support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 27 10:19:39 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/5009/1/src/osmo_gsm_tester/modem.py
File src/osmo_gsm_tester/modem.py:

Line 340:     CTX_PROT_IPv46 = 'dual'
> (is this used internally only? I'd suggest using the same strings as you've
That's expected to be used by tests when telling the modem to create a IPv4 context, an IPv6 one or a context supporting both.

It's already used in the ping.py test, although now we only use the IPv4 one because the other ones are not working properly with the modem I was using, we need to investigate that further.

About the naming, I took that naming because afaik we are using that 46 naming already in osmocom in several places and it's common. The strings need to be that way because that's how they are defined in ofono API.


-- 
To view, visit https://gerrit.osmocom.org/5009
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I605ba1bb1103a045a9b5d0e7215c05dfc1fe575f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list