osmo-ggsn[master]: sanitize build: ensure uint16/32 alignment in gtpie_test and...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Nov 23 13:30:37 UTC 2017


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/4915/4/tests/lib/in46a_test.c
File tests/lib/in46a_test.c:

Line 175: 	/* uint32_t must be 4-byte aligned to not trigger sanitize build failure */
Using osmo_load32le(&eua.v[2]) will eliminate both sanitize issue and the need to introduce extra variable.


-- 
To view, visit https://gerrit.osmocom.org/4915
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb16450af942d6464211e190f6a4d5a1d814842
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list