[MERGED] osmo-iuh[master]: sccp_sap_up(): Fix never-hit "default" case in switch

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Nov 21 18:44:34 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: sccp_sap_up(): Fix never-hit "default" case in switch
......................................................................


sccp_sap_up(): Fix never-hit "default" case in switch

As the default was called "defualt", it became a standard C label
and was never actually performing any default catch-all behavior.

As we didn't use -Wall, gcc never warned us about it so far :/

Change-Id: I9dbad21e75a55ad91b12d3d3ee8bd6dfb5326c3e
---
M src/hnbgw_cn.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/hnbgw_cn.c b/src/hnbgw_cn.c
index 81ef670..3238f00 100644
--- a/src/hnbgw_cn.c
+++ b/src/hnbgw_cn.c
@@ -389,7 +389,7 @@
 	case OSMO_PRIM(OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_INDICATION):
 		rc = handle_cn_disc_ind(cnlink, &prim->u.disconnect, oph);
 		break;
-	defualt:
+	default:
 		LOGP(DMAIN, LOGL_ERROR,
 			"Received unknown prim %u from SCCP USER SAP\n",
 			OSMO_PRIM_HDR(oph));

-- 
To view, visit https://gerrit.osmocom.org/4944
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9dbad21e75a55ad91b12d3d3ee8bd6dfb5326c3e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list