osmo-pcu[master]: AllocTest: remove assumption on max MS class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Nov 21 14:25:06 UTC 2017


Patch Set 1: Code-Review-1

(3 comments)

Well. There are more assumptions in this code.. I pointed to two.. there is probably another one...

https://gerrit.osmocom.org/#/c/4958/1/tests/alloc/AllocTest.cpp
File tests/alloc/AllocTest.cpp:

Line 444: 	  for (int ms_class = 0; ms_class < 30; ++ms_class)
missing..


Line 450: 	for (int i = 0; i < 30; ++i)
missing..


Line 855: 	test_many_connections(alloc_algorithm_b, 29, "B");
surprising... any explanation?


-- 
To view, visit https://gerrit.osmocom.org/4958
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7737f303d97197ef159b14a19c3312a11f07b433
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list