[PATCH] osmo-iuh[master]: hnbgw.c: Remove dead code creating libsctp linker dependency

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Nov 21 07:34:34 UTC 2017


Review at  https://gerrit.osmocom.org/4943

hnbgw.c: Remove dead code creating libsctp linker dependency

Since I8ac15fa2fd25bedb26297177e416976a5389b573 in July 2017 we are
not using sctp_*() functions directly anymore but go via
libosmo-sigtran.  However, some dead code remained in hnbgw.c, which
means that linkage will fail if compiled without any optimization,
i.e. without -O present.

Change-Id: Ifbcb21d43e17bf512bc7b219e590410e06c434ca
---
M src/hnbgw.c
1 file changed, 0 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/43/4943/1

diff --git a/src/hnbgw.c b/src/hnbgw.c
index c9fdd53..97905b3 100644
--- a/src/hnbgw.c
+++ b/src/hnbgw.c
@@ -238,21 +238,6 @@
 	return rc;
 }
 
-static int hnb_write_cb(struct osmo_fd *fd, struct msgb *msg)
-{
-	struct hnb_context *ctx = fd->data;
-	struct sctp_sndrcvinfo sinfo = {
-		.sinfo_ppid = htonl(msgb_sctp_ppid(msg)),
-		.sinfo_stream = ctx->hnbap_stream,
-	};
-	int rc;
-
-	rc = sctp_send(fd->fd, msgb_data(msg), msgb_length(msg),
-			&sinfo, 0);
-	/* we don't need to msgb_free(), write_queue does this for us */
-	return rc;
-}
-
 struct hnb_context *hnb_context_alloc(struct hnb_gw *gw, struct osmo_stream_srv_link *link, int new_fd)
 {
 	struct hnb_context *ctx;

-- 
To view, visit https://gerrit.osmocom.org/4943
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbcb21d43e17bf512bc7b219e590410e06c434ca
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list