osmo-iuh[master]: cosmetic: ranap_msg_factory: htonl instead of ntohl

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 20 16:13:32 UTC 2017


Patch Set 1:

hmm, actually you're right, I totally didn't check on it. The ip ultimately comes from mgcp_client_remote_addr_n() which says

  /* Return the MGCP GW binary IPv4 address in network byte order. */

and indeed libosmo-mgcp-client does

  mgcp->remote_addr = htonl(addr.sin_addr.s_addr);

Kind of weird why we pass a network byte order address around, but there you have it.

-- 
To view, visit https://gerrit.osmocom.org/4929
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07979252b7d5a92e8ba11fd088ee06f608fef489
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list