[PATCH] osmo-iuh[master]: cosmetic: ranap_msg_factory: htonl instead of ntohl

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Nov 19 12:03:40 UTC 2017


Review at  https://gerrit.osmocom.org/4929

cosmetic: ranap_msg_factory: htonl instead of ntohl

In new_transp_layer_addr(), we're composing an outgoing PDU, hence the proper
function to call would be htonl(), not ntohl().

Change-Id: I07979252b7d5a92e8ba11fd088ee06f608fef489
---
M src/ranap_msg_factory.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/29/4929/1

diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c
index 8e4954a..4f7fdb7 100644
--- a/src/ranap_msg_factory.c
+++ b/src/ranap_msg_factory.c
@@ -638,7 +638,7 @@
 {
 	uint8_t *buf;
 	unsigned int len;
-	uint32_t ip_h = ntohl(ip);
+	uint32_t ip_h = htonl(ip);
 
 	if (use_x213_nsap) {
 		len = 160/8;

-- 
To view, visit https://gerrit.osmocom.org/4929
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07979252b7d5a92e8ba11fd088ee06f608fef489
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list