osmocom-bb[master]: mobile: Avoid msg_ref going out of sync

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Nov 18 19:32:16 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4911/1/src/host/layer23/src/mobile/gsm411_sms.c
File src/host/layer23/src/mobile/gsm411_sms.c:

Line 380: 	rc = gsm340_rx_tpdu(trans, msg, rph->msg_ref);
msg_ref is passed in as arg, gets logged above, and then this here is using rpg->mgs_ref and the function arg remains unused?


-- 
To view, visit https://gerrit.osmocom.org/4911
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bac5f06921b5fd85a98d97770d42d4858ca1c42
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list