libosmocore[master]: rate_ctr: doc: explain intentional "mem leak" for mangled gr...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Nov 18 10:28:17 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4866/1/src/rate_ctr.c
File src/rate_ctr.c:

Line 185:  * Attention: if the description struct (\a desc) contains invalid characters, a mangled description
Actually, if it behaves like this, I think it's a bug.  We cannot create a copy of the descriptor every time we call rate_ctr_group_alloc(), this could create a nightmare.  We would need to create only a single copy and then re-use that every time the same group_desc is provided.  Or simply don't support this name mangling at all anymore, but that breaks compatibility with old code.


-- 
To view, visit https://gerrit.osmocom.org/4866
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35363c4c1fa0d62fd7fed40fe689487244248a3f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list