[PATCH] libosmocore[master]: build, jenkins: use only CFLAGS, not CPPFLAGS as well

[Neels Hofmeyr]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/4859

to look at the new patch set (#2).

build, jenkins: use only CFLAGS, not CPPFLAGS as well

Looking at jenkins 'make V=1' output shows that we pass various flags twice.
Apparently only CFLAGS is sufficient and CPPFLAGS are not needed.

Drop CPPFLAGS, keep only CFLAGS, for sanitize, -Wfoo, -DFOO args, in
configure.ac and jenkins.sh.

Change-Id: If94318efa6d4e38d1c97c523ebcc000fdc14ce32
---
M configure.ac
M contrib/jenkins.sh
2 files changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/59/4859/2

diff --git a/configure.ac b/configure.ac
index a8c1d2e..a1cece7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -263,11 +263,9 @@
 if test x"$sanitize" = x"yes"
 then
 	CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined"
-	CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
 CFLAGS="$CFLAGS -DBUILDING_LIBOSMOCORE -Wall"
-CPPFLAGS="$CPPFLAGS -DBUILDING_LIBOSMOCORE -Wall"
 
 AC_ARG_ENABLE(simd,
 	[AS_HELP_STRING(
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 5798c95..a649952 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -15,7 +15,7 @@
 
     prep_build "$src_dir" "$build_dir"
 
-    "$src_dir"/configure --enable-static $ENABLE_SANITIZE CFLAGS="-Werror" CPPFLAGS="-Werror"
+    "$src_dir"/configure --enable-static $ENABLE_SANITIZE CFLAGS="-Werror"
     $MAKE $PARALLEL_MAKE check \
         || cat-testlogs.sh
 }

-- 
To view, visit https://gerrit.osmocom.org/4859
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If94318efa6d4e38d1c97c523ebcc000fdc14ce32
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder