osmo-mgw[master]: vty: do not change number_endpoints at runtime

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Nov 14 08:48:29 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4779/1/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

Line 523: 	}
This is one of the annoyances of the VTY or at least how we write it. In the past I have nacked ad-hoc changes. The reasons are:

* It generally violates principle of least surprise (e.g. if you see osmo-nitb/bsc where some changes take effect immediately, some on next BTS connection and others only after restart.
* It requires documentation "classes" of when something is used.

In this case. Can't we avoid it? Just grow the array and forbid it to shrinking? This works when initialized to 0 and then can be used to grow it? Okay, then one can't shrink it. Allow to shrink when the higher endpoints are blocked and unallocated? Okay more complicated but maybe better?


-- 
To view, visit https://gerrit.osmocom.org/4779
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3994af016fb96427263edbba05f560743f85fdd4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list