[MERGED] osmo-ggsn[master]: gtp-kernel: Add function name to pdp_debug() function calls

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Nov 13 15:23:27 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: gtp-kernel: Add function name to pdp_debug() function calls
......................................................................


gtp-kernel: Add function name to pdp_debug() function calls

This allows us to distinguish "add" from "del" operatons in the log

Change-Id: Ibe2e76a6eecc7b5fa5f44ab2c1578597138e30b9
---
M ggsn/gtp-kernel.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn/gtp-kernel.c b/ggsn/gtp-kernel.c
index 0f18002..98d524b 100644
--- a/ggsn/gtp-kernel.c
+++ b/ggsn/gtp-kernel.c
@@ -35,7 +35,7 @@
 
 #include "gtp-kernel.h"
 
-static void pdp_debug(struct pdp_t *pdp)
+static void pdp_debug(const char *prefix, struct pdp_t *pdp)
 {
 	struct in46_addr ia46;
 	struct in_addr ia;
@@ -43,7 +43,7 @@
 	in46a_from_eua(&pdp->eua, &ia46);
 	gsna2in_addr(&ia, &pdp->gsnrc);
 
-	LOGPDPX(DGGSN, LOGL_DEBUG, pdp, "v%u TEID %"PRIu64"x EUA=%s SGSN=%s\n", pdp->version,
+	LOGPDPX(DGGSN, LOGL_DEBUG, pdp, "%s v%u TEID %"PRIu64"x EUA=%s SGSN=%s\n", prefix, pdp->version,
 		pdp->version == 0 ? pdp_gettid(pdp->imsi, pdp->nsapi) : pdp->teid_gn,
 		in46a_ntoa(&ia46), inet_ntoa(ia));
 }
@@ -139,7 +139,7 @@
 	struct gtp_tunnel *t;
 	int ret;
 
-	pdp_debug(pdp);
+	pdp_debug(__func__, pdp);
 
 	t = gtp_tunnel_alloc();
 	if (t == NULL)
@@ -173,7 +173,7 @@
 	struct gtp_tunnel *t;
 	int ret;
 
-	pdp_debug(pdp);
+	pdp_debug(__func__, pdp);
 
 	t = gtp_tunnel_alloc();
 	if (t == NULL)

-- 
To view, visit https://gerrit.osmocom.org/4822
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe2e76a6eecc7b5fa5f44ab2c1578597138e30b9
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list