[PATCH] osmo-ggsn[master]: Align logging for APN start in kernel-gtp case with that of TUN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Nov 12 22:13:56 UTC 2017


Review at  https://gerrit.osmocom.org/4817

Align logging for APN start in kernel-gtp case with that of TUN

Change-Id: Ie53d37f151e8b6448636a8cde5777b3841989d05
---
M ggsn/ggsn.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/17/4817/1

diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index 1d4e592..0beaef7 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -260,12 +260,12 @@
 		apn->tun.tun->priv = apn;
 		break;
 	case APN_GTPU_MODE_KERNEL_GTP:
+		LOGPAPN(LOGL_INFO, apn, "Opening Kernel GTP device %s\n", apn->tun.cfg.dev_name);
 		if (apn->cfg.apn_type_mask & (APN_TYPE_IPv6|APN_TYPE_IPv4v6)) {
 			LOGPAPN(LOGL_ERROR, apn, "Kernel GTP currently supports only IPv4\n");
 			apn_stop(apn, false);
 			return -1;
 		}
-		LOGPAPN(LOGL_ERROR, apn, "Setting up Kernel GTP\n");
 		/* use GTP kernel module for data packet encapsulation */
 		if (gtp_kernel_init(apn->ggsn->gsn, apn->tun.cfg.dev_name,
 				    &apn->v4.cfg.ifconfig_prefix, apn->tun.cfg.ipup_script) < 0) {

-- 
To view, visit https://gerrit.osmocom.org/4817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie53d37f151e8b6448636a8cde5777b3841989d05
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list