[MERGED] osmo-bsc[master]: osmo-bsc: Print NOTICE message on unimplemented BSSMAP UDT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Nov 12 14:36:11 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: osmo-bsc: Print NOTICE message on unimplemented BSSMAP UDT
......................................................................


osmo-bsc: Print NOTICE message on unimplemented BSSMAP UDT

When we receive unimplemented/unhandled message types, we shouldn't
simply silently discard them, but print a log message for the
benefit of the user.

Change-Id: I65489578b1c214f193b1ce0e9ba59432dcd42a3e
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 9f8032e..59c2979 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -645,6 +645,10 @@
 	case BSS_MAP_MSG_PAGING:
 		ret = bssmap_handle_paging(msc, msg, length);
 		break;
+	default:
+		LOGP(DMSC, LOGL_NOTICE, "Received unimplemented BSSMAP UDT %s\n",
+			gsm0808_bssmap_name(msg->l4h[0]));
+		break;
 	}
 
 	return ret;

-- 
To view, visit https://gerrit.osmocom.org/4788
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65489578b1c214f193b1ce0e9ba59432dcd42a3e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list