This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/4780 MGCP endpoints: parse as decimal, not hex Parse the endpoint index from the MGCP messages as base-10, not 16. If osmo-mgw parses the endpoint IDs as base-16 numbers while OsmoMSC and OsmoBSC pass in decimal endpoint numbers, the consequence is, for example: - I configure 32 endpoints in osmo-mgw, - I tell OsmoBSC to use endpoint range 1-32, - At some point OsmoBSC may pass in, say, "30 at mgw", - "30" is parsed base-16 and ends up being endpoint index 48, instead of 32, - OsmoMGW sees that 48 > number_endpoints and barfs. Related: OS#2633 Change-Id: Ic18608ff23303c1564548a86d5f6bfa539fe555e --- M src/libosmo-mgcp/mgcp_msg.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/80/4780/1 diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index d686bca..763a5a1 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -192,7 +192,7 @@ if (strncmp(mgcp, "ds/e1", 5) == 0) return find_e1_endpoint(cfg, mgcp); - gw = strtoul(mgcp, &endptr, 16); + gw = strtoul(mgcp, &endptr, 10); if (gw > 0 && gw < cfg->trunk.number_endpoints && endptr[0] == '@') return &cfg->trunk.endpoints[gw]; -- To view, visit https://gerrit.osmocom.org/4780 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic18608ff23303c1564548a86d5f6bfa539fe555e Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>