osmocom-bb[master]: mobile/gsm322.c: prevent buffer over-/under-run

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Nov 8 19:08:45 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4729/1/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:

Line 326: 	OSMO_ASSERT(value > 0 && value < 128);
if you assert > 0 here, the "== 0" below will never be used.  Sure you didn't mean >= 0?


-- 
To view, visit https://gerrit.osmocom.org/4729
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12587a6c6456b8663e5357cf68a22c6d1927a07
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list