This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/4716/1//COMMIT_MSG Commit Message: Line 15: This fixes CID 178664 please use "Fixes: Coverity CID#178664" like in our other related comits. Thisis machine-parseable. We don't have any code that parses it yet (AFAIK) but this is useful in the future. https://gerrit.osmocom.org/#/c/4716/1/src/libcommon-cs/a_reset.c File src/libcommon-cs/a_reset.c: Line 141: if (strlen(name) >= sizeof(reset->name)) where does 'reset->name' come from? why is there a separate name at all? Isn't the fsm->name sufficient which we allocate/create below? I think I raised this question before in code review but don't recall an answer, sorry. -- To view, visit https://gerrit.osmocom.org/4716 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c4a7ff17e1c8ceb6e543ab6f0f07c87df603c7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes