[MERGED] osmo-trx[master]: SocketsTest: Fix printing of non-nul-terminated string

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Nov 7 20:32:09 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: SocketsTest: Fix printing of non-nul-terminated string
......................................................................


SocketsTest: Fix printing of non-nul-terminated string

Change-Id: I33d0ddf851d84b81ab5252e3755422170cee54ee
Fixes: Coverity CID#149363
---
M CommonLibs/SocketsTest.cpp
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/CommonLibs/SocketsTest.cpp b/CommonLibs/SocketsTest.cpp
index c2849e0..3198a5e 100644
--- a/CommonLibs/SocketsTest.cpp
+++ b/CommonLibs/SocketsTest.cpp
@@ -61,7 +61,8 @@
 	readSocket.nonblocking();
 	int rc = 0;
 	while (rc<gNumToSend) {
-		char buf[MAX_UDP_LENGTH];
+		char buf[MAX_UDP_LENGTH+1];
+		buf[MAX_UDP_LENGTH] =  '\0';
 		int count = readSocket.read(buf, MAX_UDP_LENGTH);
 		if (count>0) {
 			COUT("read: " << buf);

-- 
To view, visit https://gerrit.osmocom.org/4696
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33d0ddf851d84b81ab5252e3755422170cee54ee
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list