This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/4678/1//COMMIT_MSG
Commit Message:
Line 8:
Please kindly give the change log more context/description on what is fixed, why and how. Also, it is not a LC15 specific change, so let's drop this from the subject? Thanks!
https://gerrit.osmocom.org/#/c/4678/1/src/bts.cpp
File src/bts.cpp:
Line 1638: if (!strcmp(p, "PH-DATA")) {
i don't think it is very elegant to use string-compares on a string that is originally only intended to facilitate logging. We don't do this anywhere else. AFAICT. I would prefer a different solution, either passing a 'bool is_rach' argument to the function/method, or maybe even having one set_tbf_ra() (which appears to be the case for RACH) and one update_tbf_ra() for the relative/delta updates later?
--
To view, visit https://gerrit.osmocom.org/4678
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65212f8203f1a35278890f51db038d689b2493d5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes