[MERGED] osmo-bts[master]: trx: Avoid NULL+1 dereference in trx_ctrl_read_cb()

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: trx: Avoid NULL+1 dereference in trx_ctrl_read_cb()
......................................................................


trx: Avoid NULL+1 dereference in trx_ctrl_read_cb()

We unconditionally pass "p+1" into sscanf() despite not knowing
if 'p' is NULL or not.

Change-Id: I40a49c3feb3b55ef577eebd7d567afdbcfe0d624
Fixes: Coverity CID#178661
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 5d8f6c4..1332854 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -397,7 +397,9 @@
 			goto notmatch;
 
 		/* check for response code */
-		sscanf(p + 1, "%d", &resp);
+		resp = 0;
+		if (p)
+			sscanf(p + 1, "%d", &resp);
 		if (resp) {
 			LOGP(DTRX, (tcm->critical) ? LOGL_FATAL : LOGL_NOTICE,
 				"transceiver (%s) rejected TRX command "

-- 
To view, visit https://gerrit.osmocom.org/4685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40a49c3feb3b55ef577eebd7d567afdbcfe0d624
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder