osmo-mgw[master]: cosmetic: make dummy packet handling more explicit

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 1 12:04:14 UTC 2017


Patch Set 2: Code-Review+1

(5 comments)

https://gerrit.osmocom.org/#/c/4617/2/include/osmocom/mgcp/mgcp.h
File include/osmocom/mgcp/mgcp.h:

Line 102:  * sent. The beviour is controlled viw the keepalive_interval member of the
("via" or "by"?)


Line 108:  * value is used as interval. See also mgcp_keepalive_timer_cb(),
(the a)


https://gerrit.osmocom.org/#/c/4617/2/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

Line 669: 	/* Send dummy packet, see also commens in mgcp_keepalive_timer_cb() */
(comments)


Line 670: 	OSMO_ASSERT(tcfg->keepalive_interval >= -1);
(rather use the defined constant?)

(I guess Holger would say: do we really need to crash the program with the assertion, can't we just do 'if (interval <= MGCP_KEEPALIVE_NEVER)' below?)


Line 824: 			send_dummy(endp, conn);
(our usual coding style would have avoided the nested if)


-- 
To view, visit https://gerrit.osmocom.org/4617
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7ee9409baec50a09fb357d655b5253434fae924
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list