osmo-gsm-tester[master]: Move Sms class to a separate module

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue May 30 15:37:15 UTC 2017


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/2796/2/src/osmo_gsm_tester/sms.py
File src/osmo_gsm_tester/sms.py:

Line 49:     def src_msisdn():
When moving code, please don't include modifications (if you really have to, they must be described in the commit log). Please add new functions in a separate patch, best along with the patch that is then using these functions.


-- 
To view, visit https://gerrit.osmocom.org/2796
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f28e14e963abb64df687b69d54975be2aeb0d0d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list